fix: gate proto tests behind protobuf feature flag - #97
Merged
Conversation
the proto integration tests spawn ember-server with --protobuf, but without the protobuf feature enabled the binary doesn't recognize the flag and exits immediately. this caused 44 test timeouts (5s each) and resource contention that made other tests flaky. - add `protobuf` feature to integration test crate - gate `mod proto` behind `#[cfg(feature = "protobuf")]` - update Makefile test/clippy targets to use `--features protobuf` - update CI build/test/clippy steps to use `--features protobuf`
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
the proto integration tests spawn ember-server with --protobuf, but without the protobuf feature enabled the binary doesn't recognize the flag and exits immediately. this caused 44 test timeouts (5s each) and resource contention that made other tests flaky. - add `protobuf` feature to integration test crate - gate `mod proto` behind `#[cfg(feature = "protobuf")]` - update Makefile test/clippy targets to use `--features protobuf` - update CI build/test/clippy steps to use `--features protobuf`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
proto integration tests were failing because they spawn
ember-serverwith--protobuf, but the binary was compiled without theprotobuffeature. the server didn't recognize the flag and exited immediately, causing 44 tests to timeout after 5 seconds each. the resource contention from these timeouts also madebasic_operations::existsflaky.gates the proto test module behind a
protobuffeature flag and updates the Makefile + CI to build/test with--features protobuf.what was tested
cargo test --workspace— proto tests skipped, all 301 tests passcargo test --workspace --features protobuf— all 335 tests pass (including 34 proto tests)make check— fmt, clippy, and tests all pass